Kong / Kong/unirest-python

Plus character + is not properly quoted

Open
#45 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
434
Forks
103
PR merge metrics
No merged PRs in 30d

Description

I sent a request that contained a plus + character in the body and noticed that it gets replaced by a space. As you might know many web servers do this therefore the character should be quoted to %2B by unirest or data will be malformed unless you compensate for this. This is for all urlencoded data both in the query string and url encoded post body. Urllib does not have this problem in functions such as quote or urlencode

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by inspecting unirest-python's URL-encoding handling for query strings and URL-encoded POST bodies, comparing it with urllib's quote and urlencode functions mentioned in the issue. Done means a plus character is sent as %2B in both contexts instead of becoming a space.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.