Kong / Kong/insomnia

Accessibility - Screen reader doesn't detect when a modal opens automatically anymore

Open
#5,986 1 comment 0 reactions 0 assignees View on GitHub
B-bug S-unverified
Dominant language
TypeScript
Stars
40k
Forks
2.4k
Avg merge
2d 13h
Merged PRs (30d)
61

Description

### Expected Behavior

When a modal opens, for example the environment editor, the screen reader should speak it opened.

### Actual Behavior

When pressing CONTROL+E, the screen reader speaks nothing, and pressing tab gives the impression the modal didn't open, because it goes to the send button of the request. To access the modal, at present, it's necessary to press SHIFT+TAB various times or, a faster method, set the screen reader to browse mode instead of focus mode and pressing CONTROL+HOME.

### Reproduction Steps

1. With Narrator or NVDA, open Insomnia.

2. Press CONTROL+E to open for example the environments dialog. You will notice Narrator or NVDA won't speak.

3. Press tab. It will go to the send button.

4. To go to the modal, there are two options:

- If Narrator or NVDA are in focus mode (most likely), toggle browse mode by pressing INSERT+SPACE. If you press CONTROL+HOME in browse mode, on narrator it will read the dialog contents.
NVDA will speak "dialog" and will require to press space or ENTER on it to open, but this is a default NVDA behavior.

I found issue #5494 that gave me the idea to test on Insomnia 2022.6.0, on this version NVDA or narrator speaks the modal correctly and doesn't require to manually open it with browse mode. Also tab cycles by the modal content instead of going to the request's send button on this version.

### Is there an existing issue for this?

- [X] I have searched the [issue tracker](https://www.github.com/Kong/insomnia/issues) for this problem.

### Additional Information

Tested with [NVDA](https://nvaccess.org) version 2023.1.

### Insomnia Version

2023.2.2

### What operating system are you using?

Windows

### Operating System Version

Windows 11 22H2

### Installation method

Tested the installed version and running from latest develop branch.

### Last Known Working Insomnia version

2022.6.0

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue in Insomnia 2023.2.2 on Windows 11 with Narrator or NVDA, using Control+E to open the environments dialog and then pressing Tab. Trace the modal entry point and compare its behavior with Insomnia 2022.6.0; done means the screen reader announces the automatically opened modal and Tab remains within its content.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, typescript
Domain
accessibility, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.