Keybindings don't respect keymap
- Dominant language
- TypeScript
- Stars
- 40k
- Forks
- 2.4k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 61
Description
### Expected Behavior
I press Ctrl+E and the environment editor opens.
### Actual Behavior
A modal to duplicate a request opens instead.
### Reproduction Steps
1. On a Linux machine with a Querty keyboard
2. Set an alternative keyboard layout (Dvorak)
3. In the main window, press Ctrl+E to open the environment editor (On Drovak, the E is mapped onto the D-key)
4. Duplicate request modal opens
### Is there an existing issue for this?
- [X] I have searched the [issue tracker](https://www.github.com/Kong/insomnia/issues) for this problem.
### Additional Information
It's on a Linux machine, with a Querty keyboard but a Dvorak layout (`setxkbmap dvorak`).
Shortcuts defined in the window-menus **do** work as expected (e.g.: toggle devtools, hide, quit).
A quick look at the changelog points to #4937 as the cause.
```
Version: Insomnia 2022.7.0
Build date: 12/15/2022
OS: Linux x64 5.15.81-1-MANJARO
Electron: 22.0.0
Node: 16.17.1
V8: 10.8.168.20-electron.0
Architecture: x64
```
### Insomnia Version
2022.7.0
### What operating system are you using?
Other Linux
### Operating System Version
Linux x64 5.15.81-1-MANJARO
### Installation method
pamac
### Last Known Working Insomnia version
2022.6.0
Contributor guide
Research direction
Reproduce the shortcut conflict in the main window on Linux with a Dvorak layout, then inspect the keybinding handling associated with the change in #4937. Done means Ctrl+E opens the environment editor, while the duplicate-request modal does not open; existing window-menu shortcuts should continue to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- electron, typescript
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100