'Single quotes' are being encoded in URL
- Dominant language
- TypeScript
- Stars
- 40k
- Forks
- 2.4k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 61
Description
### Expected Behavior
As per https://datatracker.ietf.org/doc/html/rfc3986#section-2.2, single quotes are delimiter characters so they should not be encoded. This is even hinted at in the comment here: https://github.com/Kong/insomnia/blob/develop/packages/insomnia-url/src/querystring.ts#L11. I wonder what the cause for excluding this character was.
### Actual Behavior
Single quotes encoded to %27
### Reproduction Steps
_No response_
### Is there an existing issue for this?
- [X] I have searched the [issue tracker](https://www.github.com/Kong/insomnia/issues) for this problem.
### Additional Information
_No response_
### Insomnia Version
2022.2.1
### What operating system are you using?
Ubuntu
### Operating System Version
Ubuntu 21.10
### Installation method
AppImage
### Last Known Working Insomnia version
_No response_
Contributor guide
Research direction
Inspect packages/insomnia-url/src/querystring.ts and the linked RFC 3986 section to understand how single quotes are classified during URL encoding. Reproduce the reported behavior in Insomnia, then verify that single quotes remain unencoded without changing other query-string encoding behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100