[Bug] Oauth 1 signature calculations does not include body
Open
Nobody has claimed this yet.
A-oauth
B-bug
E-good-first-issue
- Dominant language
- TypeScript
- Stars
- 40k
- Forks
- 2.4k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 61
Description
- Insomnia Version: 6.0.2
- Operating System: Win 7 SP2
## Details
According to the specification, body parameters are included in signature calculations. This is done by putting them in the requestData.data object for oauth-1.0a. However, this isn't done in the linking code. I guess this is because there's no nice way to deal with body content as parameters.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the linking code that builds requestData for oauth-1.0a, then trace how request body parameters are represented. Compare the signature input with the OAuth 1.0 specification and verify that body parameters are included in calculations; the issue names no specific files or tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100