KnpLabs / KnpLabs/php-github-api

ResultPager fetchall on apps/installations incorrect result

Open
#597 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
PHP
Stars
2.2k
Forks
587
PR merge metrics
No merged PRs in 30d

Description

See https://platform.github.community/t/pagination-differs-in-installations-api/1862

The result is an array with a count field and and subarray of all installations but we merge result when using the fetchAll method

We need to check if this is something we need/can fix in code or if we should add some docs about this issue

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing ResultPager's fetchAll handling for the apps/installations endpoint and compare it with the endpoint's documented array, count, and installations structure. Determine whether the client can return that structure correctly or whether the behavior needs documentation; done means resolving that choice and covering the resulting behavior or guidance.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, php
Domain
api
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.