KnpLabs / KnpLabs/KnpDisqusBundle

SSO service is overwritten

Open
#46 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
62
Forks
18
PR merge metrics
No merged PRs in 30d

Description

It seems the `$parameters['sso']['service']` is overwritten [here](https://github.com/KnpLabs/KnpDisqusBundle/blob/master/Templating/Helper/DisqusHelper.php#L50), and the generated value from `getSsoParameters` does not include the `service`.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in Templating/Helper/DisqusHelper.php at the linked line and inspect how getSsoParameters builds the SSO data. Confirm why the supplied $parameters['sso']['service'] is overwritten and why the generated value omits service. Done means the configured service is preserved in the resulting SSO parameters.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, symfony
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.