Knockout-Contrib / Knockout-Contrib/KoGrid
Count on initial grid with no items
- Dominant language
- JavaScript
- Stars
- 277
- Forks
- 124
- PR merge metrics
- No merged PRs in 30d
Description
Total Items shown in the footer for an empty grid is 1, when it should be 0 (zero) since, well, it's empty.
I believe this can be fixed at line 1556 via the following:
```
return self.config.pagingOptions.totalServerItems() || self.sortedData().length || 0;
```
instead of using:
```
return self.MaxRows();
```
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at line 1556, where the footer's Total Items value is calculated, and compare the current MaxRows() result with the proposed empty-grid behavior. Verify that an empty grid displays 0 while the count remains correct when items or server totals are present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100