Knockout-Contrib / Knockout-Contrib/KoGrid
Issue with dateSort
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 277
- Forks
- 124
- PR merge metrics
- No merged PRs in 30d
Description
In sortService.js line #174 shouldn't
mtch = b.match(dateRE); be
mtch = b.match(window.kg.sortService.dateRE);
???
I am not sure if I do the procedure correctly:
https://github.com/hkosmidi/KoGrid/commit/d5d4251526540149e157f24ac8e1fe9314e1f887
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect sortService.js at line 174 and compare the reported dateSort change with commit d5d4251526540149e157f24ac8e1fe9314e1f887. Confirm whether the date regular expression should be referenced through window.kg.sortService.dateRE, and consider the issue complete when dateSort uses the correct reference.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100