Knockout-Contrib / Knockout-Contrib/KoGrid

Group panel, remove configured group error.

Open
#288 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
277
Forks
124
PR merge metrics
No merged PRs in 30d

Description

```
TypeError: col is undefined
http://debian/fsp/dist/js/vendor/KoGrid/koGrid-2.0.6.debug.js
Line 1516
```

At:

```
col.isGroupedBy(false);
```

Actually: `Compiled At: 01/11/2013 15:58:36`, just pasted in that file.

Reproduce:
- `showGroupPanel: true`.
- `groups: ['parent_id']`. (without hard-coded groups it works as intended)
- Manually add another group field. (actually not required to error)
- Attempt to remove first group field with header close button.

Also triggered on group buttons in filter drop-down when a pre-set group is clicked (off). Think the `isGroupedBy` isn't being set by pre-set config.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at dist/js/vendor/KoGrid/koGrid-2.0.6.debug.js around line 1516, where col.isGroupedBy(false) is called. Reproduce with showGroupPanel enabled and groups set to ['parent_id'], then remove the first group or toggle it from the filter dropdown. Done means these actions no longer produce the TypeError.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.