Knockout-Contrib / Knockout-Contrib/KoGrid
beforeSelectionChange and afterSelectionChange not called when selection done by arrow keys
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 277
- Forks
- 124
- PR merge metrics
- No merged PRs in 30d
Description
Shouldn't moveSelectionHandler have the same before/after logic as toggleSelected?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating moveSelectionHandler and toggleSelected in the KoGrid source, then compare how each handles selection changes. Reproduce selection with arrow keys and verify whether beforeSelectionChange and afterSelectionChange are called in the expected order. Done means arrow-key selection follows the same callback behavior as toggleSelected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100