Knockout-Contrib / Knockout-Contrib/KoGrid
Problem with multi-select / removal of selected rows
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 277
- Forks
- 124
- PR merge metrics
- No merged PRs in 30d
Description
There's a bug in the grid where if you do a multi-select using shift click and then remove the selected items from the bound data the selected items will not be removed properly. Here's a plunker to demonstrate : http://plnkr.co/edit/qzIQIS68RWdQF35y3Rsp?p=preview. Select multiple items and click remove. That works fine. Then, select multiple using shift click and click remove items and it won't work.
I've found a fix for this, if you modify kogrid-debug.js around line 1824 and set :
grid.$$selectionPhase = false;
before returning true the problem is resolved.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with the linked Plunker: compare removing rows selected normally with removing rows selected using shift-click. Inspect kogrid-debug.js around line 1824 and verify the selection state during removal. Done means bound-data removal consistently removes all selected rows in both cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100