Knockout-Contrib / Knockout-Contrib/KoGrid

koGrid doesn't set checkbox properly -with code fix

Open
#199 13 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
277
Forks
124
PR merge metrics
No merged PRs in 30d

Description

When trying to set checkbox the toggleSelected return undefined value, stopping the check event chain and thereby isn't the checkbox "visually set".

Fix for my particular problem was to make the following change (line 1109)

from: afterSelectionChange: function () { },
to: afterSelectionChange: function () { return true; },

since the return statement on line 1633:
return self.afterSelectionChange(self, event);
returns undefined without the "fix" and causing the mentioned problem.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the callback definition around line 1109 and trace the call and return at line 1633. Verify the checkbox selection event and its visual state, then confirm the change with the relevant existing behavior or tests; done means the checkbox is visibly set without stopping the event chain.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.