Knockout-Contrib / Knockout-Contrib/Knockout-Validation

ko.validation.group performance hit

Open
#73 15 comments 0 reactions 0 assignees View on GitHub
circle back
Dominant language
JavaScript
Stars
1k
Forks
366
PR merge metrics
No merged PRs in 30d

Description

We have a view model with very few observables, and only 1 that has validation, it has a observableArray with ~90 items, it also as very few observables and one with validation so we have 90 + 1 that needs to be tracked by the validation framework.

ko.validation.group(this) takes 350 ms in firefox / chrome and in IE7 the script wont complete, it hangs and says that the script didnt respond

Looks like there are serious performance problems with ko.validation.group, i need it to disable save buttons and such

Thanks, Anders

Contributor guide

Open the contributing guide

Research direction

Start at ko.validation.group and reproduce the reported case with a view model containing an observableArray of about 90 items and one validated observable. Compare execution in Firefox, Chrome, and IE7; done means the grouping completes without the reported hang and its performance is substantially improved.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.