Knockout-Contrib / Knockout-Contrib/Knockout-Validation

False positives on form submit

Open
#634 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1k
Forks
366
PR merge metrics
No merged PRs in 30d

Description

False positives are being generated on form submission. Strangely, it is place-based, e.g. the first test, I get false-positives on observables in position 2 & 4, where there are 5 observables that are functionally similar and grouped together.

If I move these around, so that the observables that were in positions 2 and 4 are now in other positions, when i submit I still get false positives in position 2 & 4, while the fields that originally held those positions are now true positives. see: http://stackoverflow.com/questions/39855881/error-with-knockout-validation-validation

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the reproduction described in the issue and the linked Stack Overflow example, then trace the form-submission validation path in the repository. No source files or tests are named, so first identify the relevant validation entry point and existing test coverage. Done means equivalent observables validate according to their values rather than their positions, with a regression test for the reported arrangement.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.