Knockout-Contrib / Knockout-Contrib/Knockout-Validation
requiresOneOf user contributed rule has undefined variable "required"
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1k
- Forks
- 366
- PR merge metrics
- No merged PRs in 30d
Description
Hi!
It looks like there is an issue in the code on user contributed rules page
if (val === undefined || val === null) return !required;
Variable required isn't declared.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open the User-Contributed-Rules wiki page linked in the issue and inspect the requiresOneOf example around the shown snippet. Check the rule for an undeclared variable and update the example so its references are valid; done means the published snippet no longer contains the undefined reference.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- documentation
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100