Knockout-Contrib / Knockout-Contrib/Knockout-Validation
add options to insert error on element based on selector
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1k
- Forks
- 366
- PR merge metrics
- No merged PRs in 30d
Description
is possible to insert the message based on selector
like this
ko.validation.configure({
insertMessages: true,
decorateElement: true,
errorElementClass: 'error',
errorElementSelector: 'control-group',
errorMessageClass: 'help-inline'
});
<div class="control-group" /* data-bind="validationElement: Description" <-- not needed */ >
<label class="control-label" for="inputDescription">Description</label>
<div class="controls">
<input id="inputDescription" type="text" data-bind="value: Description" maxlength="100" required />
</div>
</div>
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the validation message insertion and configuration handling in the Knockout-Validation codebase. Compare the requested errorElementSelector behavior with the existing validationElement binding and the provided control-group markup. Done means selector-based insertion works without requiring validationElement on the wrapper and preserves the configured message and element classes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100