Knockout-Contrib / Knockout-Contrib/Knockout-Validation

HTML5 attributes: no error css class applied to validated element in these cases?

Open
#205 9 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
1k
Forks
366
PR merge metrics
No merged PRs in 30d

Description

Hello guys.

I've built a small demo which shows the problem: http://jsfiddle.net/luisabreu/WMdLb/5/

It seems like using the html5 required attribute is not enough for getting a validation error when a field is empty. Removing the extend method comment makes it work as expected though.

Contributor guide

Open the contributing guide

Research direction

Start with the linked JSFiddle demo and reproduce the behavior using an HTML5 required attribute on an empty field. Inspect how the extend method affects validation and CSS-class application; done means the validated empty element receives the expected validation error class without removing that method.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.