KitwareMedical / KitwareMedical/lungair-desktop-application
decouple SegmentationModel from Xray
- Dominant language
- Python
- Stars
- 7
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Description
Once #41 is merged, we should decouple `SegmentationModel` from `Xray`:
- Remove the `seg_model` member variable from `Xray` objects, making `seg_model` instead an argument in `Xray.add_segmentation`
- Revert `HomeLogic.seg_model` to being a `SegmentationModel` rather than a dict.
See
- https://github.com/KitwareMedical/lungair-desktop-application/pull/41#discussion_r955069977
- https://github.com/KitwareMedical/lungair-desktop-application/pull/41#discussion_r955068913
Contributor guide
Research direction
Review the linked pull request discussions first, then locate Xray.add_segmentation and the HomeLogic.seg_model usage. The work is done when Xray no longer stores seg_model, add_segmentation receives it as an argument, and HomeLogic.seg_model is again a SegmentationModel rather than a dict.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- desktop, machine-learning
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100