Kinto / Kinto/kinto

/buckets/a/collections/b?_limit="5" is allowed

Open
#1,694 2 comments 0 reactions 0 assignees View on GitHub
protocol stale
Dominant language
Python
Stars
4.4k
Forks
437
Avg merge
1d 2h
Merged PRs (30d)
15

Description

While investigating how best to implement the Kinto side of push notifications, I settled on using ETag as the "current version" to include in push notifications. I was worried about this at first, but @leplatrem pointed out that we support `?_since="quoted Etag"`. That's interesting, because typically `"123"` should be a string rather than a number (because we parse values with JSON). But it turns out that not only do we support `?_since="123"` (which we probably should, because it matches ETags), but we also support `?_limit="123"` (which we probably shouldn't, because there's no string format for limits).

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the collection request `/buckets/a/collections/b?_limit="5"` and trace the API's query-parameter parsing and validation. Confirm the expected behavior for quoted `_limit` and quoted `_since`; done means quoted limits are rejected without changing the supported ETag-compatible `_since` behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.