Kinto / Kinto/kinto-http.py

Check permissions method doesn't handle pagination properly

Open Beginner friendly
#388 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
53
Forks
22
Avg merge
3d 5h
Merged PRs (30d)
3

Description

permissions endpoint returns a paginated list. The current get_permissions method does not account for it.

https://github.com/Kinto/kinto-http.py/blob/1182c295f23194e8851a1df582a14153b736cfcc/src/kinto_http/client.py#L682

It should use pagination properly. This is handled appropriately in https://github.com/Kinto/kinto.js/blob/9e8086989a59beaa9616c6cd8aaa1d756cda66f4/src/http/base.ts#L849

Contributor guide

Open the contributing guide

Research direction

Start in src/kinto_http/client.py at get_permissions around line 682, then compare its pagination handling with the kinto.js implementation linked at src/http/base.ts around line 849. The work is complete when get_permissions handles the paginated permissions endpoint and returns the full list.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.