KillingSpark / KillingSpark/rustbus
MessageParser::get should handle variants specially
- Dominant language
- Rust
- Stars
- 65
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Description
#82 brought to light that variants are not very userfriendly
* Either `get()` could check if the next value is a variant and do "the right thing" but I'll have to think about whether this has any edge cases that would break if I do this.
* Or I could introduce a get_variant() that works similarly to `get()` which essentially wraps the `get::()?.get::()`
In any case, users should rarely have to actually call `get::()`
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by reading MessageParser::get and the variant behavior exposed by issue #82. Decide between special handling in get() and a separate get_variant() API; done means users rarely need to call get::() directly and the chosen behavior covers relevant edge cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend-api-design
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100