KhronosGroup / KhronosGroup/glslang

GLSL_EXT_structured_descriptor_heap is missing descriptor_size tests

Open Beginner friendly
#4,400 0 comments 0 reactions 0 assignees View on GitHub
Descriptor Heaps
Dominant language
C++
Stars
3.6k
Forks
989
Avg merge
1d 2h
Merged PRs (30d)
31

Description

The spec shows you can go `layout (descriptor_size = 128)` to set a specific size/stride

There are **zero** tests in https://github.com/KhronosGroup/glslang/pull/4272/files doing that... this **needs** to be tested

@Guang-035 / @ShchchowAMD can you guys please add this to finish the original PR

Contributor guide

Open the contributing guide

Research direction

Review the files changed in glslang PR #4272, focusing on the existing GLSL_EXT_structured_descriptor_heap tests and how layout qualifiers are exercised. Add coverage for layout(descriptor_size = 128) and run the relevant glslang test or validation suite; done means the descriptor_size stride case is tested successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers, testing
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
70/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.