KhronosGroup / KhronosGroup/glslang

glslang shouldn't require that specialization constant ids must be unique

Open
#4,064 0 comments 0 reactions 0 assignees View on GitHub
GLSL/ESSL Specification
Dominant language
C++
Stars
3.6k
Forks
989
Avg merge
1d 2h
Merged PRs (30d)
31

Description

Pending the discussion in https://github.com/KhronosGroup/SPIRV-Registry/issues/357 we should consider removing the restriction on `constant_id` qualifiers that requires them to be unique. Neither the GLSL spec nor the `GL_KHR_vulkan_glsl` extension actually require uniqueness, so if it's allowed by SPIR-V it should probably be allowed by glslang as well.

Contributor guide

Open the contributing guide

Research direction

Start by reading the linked SPIRV-Registry discussion and then trace where glslang validates that `constant_id` qualifiers are unique. Done means resolving the specification question and ensuring glslang's behavior matches the accepted SPIR-V and GLSL requirements.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.