KhronosGroup / KhronosGroup/glslang

The glslang standalone command line tool does not support system includes (#include <foo>)

Open
#3,817 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
C++
Stars
3.6k
Forks
989
Avg merge
1d 2h
Merged PRs (30d)
31

Description

This should just be supported. The standalone tool's includer also just returns null, so in order for a user to even understand that the command line tool is incomplete, they'd need to look into the source. See line 127 of the StandAlone/DirStackFileIncluder.h https://github.com/KhronosGroup/glslang/blob/b3a6aa7b03c51ba976e4f4e96b1e31f77f43f312/StandAlone/DirStackFileIncluder.h#L127-L131

Contributor guide

Open the contributing guide

Research direction

Start by reading StandAlone/DirStackFileIncluder.h at lines 127-131 and trace how the standalone command-line tool handles include requests. Confirm the expected behavior for #include ; done means system includes are supported or the tool clearly reports the limitation instead of silently returning null.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
cli, compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.