KhronosGroup / KhronosGroup/glslang
Compute derivative workgroup size error checks may raise false positives
- Dominant language
- C++
- Stars
- 3.6k
- Forks
- 989
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 31
Description
> Thanks for merging. I just noticed that since this is doing the checks as it parses the shader, whether you get an error depends on the order of setting the derivative layout vs setting the workgroup dimensions (spec constant or not). This is a pre-existing issue and not a huge deal for me, but maybe worth fixing eventually.
_Originally posted by @jeffbolznv in https://github.com/KhronosGroup/glslang/issues/3723#issuecomment-2346970795_
Contributor guide
Research direction
Start by reproducing the derivative layout and workgroup-dimension checks with the settings supplied in different orders, including specialization constants. Trace the shader parser's validation path; done means equivalent valid inputs produce consistent results regardless of setting order and false-positive errors are covered by a regression test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100