KhronosGroup / KhronosGroup/glslang
Feature Request: support mapping xfb layout qualifier in TIoMapResolver
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.6k
- Forks
- 990
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 31
Description
Currently one can provide a custom TIoMapResolver to TProgram::mapIO() to assign newBinding, newSet, newLocation etc to any IO variable as needed after linking the program. What is missing is to assign transform feedback related layout qualifier to variable such as newXfbBuffer, newXfbOffset and newXfbStride.
Because there is an OpenGL API "glTransformFeedbackVaryings" that supports assigning transform feedback layout outside of shader source code, there should be a way to assign them in glslang after linking and I think the mapIO is the place to implement it the same way as newLocation etc.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at TProgram::mapIO and TIoMapResolver's existing newBinding, newSet, and newLocation handling. Trace how transform-feedback qualifiers are represented after linking, then determine how newXfbBuffer, newXfbOffset, and newXfbStride should be assigned consistently with glTransformFeedbackVaryings; done means custom resolvers can set those qualifiers through mapIO.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100