KhronosGroup / KhronosGroup/glslang

#include file pathnames are being processed for escapes

Open
#2,142 8 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
C++
Stars
3.6k
Forks
989
Avg merge
1d 2h
Merged PRs (30d)
31

Description

### Problematic code:
**HLSL** shader with this:
```hlsl
#include "shared\common.h"
```
### Expected behaviour
Successful preprocessing and compilation.
### Current behaviour:
Preprocessing errors:
```
ERROR: common.h:4: 'string' : Invalid escape sequence
ERROR: common.h:4: 'string' : End of line in string
```

### glslang version
Built from commit 3bf1dab23d9a3af0c93ce4e717f13417df12606a

#### Misc
Seems to be related with #2108.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the HLSL example with glslang at the referenced commit and trace how the preprocessor handles the include pathname. The work is done when `shared\common.h` preprocesses and compiles successfully without invalid-escape or end-of-line string errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.