KhronosGroup / KhronosGroup/glslang
getNumLiveAttributes() is not right
Open
- Dominant language
- C++
- Stars
- 3.6k
- Forks
- 989
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 31
Description
TProgram::getNumLiveAttributes() is implemented as return getNumPipeInputs();
This is not correct, because gl_InstanceID for example is not an attribute.
Also compute shader inputs are not attributes.
Contributor guide
Research direction
Locate TProgram::getNumLiveAttributes() and trace how getNumPipeInputs() is used to derive the current count. Check the handling of gl_InstanceID and compute shader inputs, then verify that the resulting count includes only live attributes and add or run the relevant compiler tests if available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100