KhronosGroup / KhronosGroup/glslang
cannot query live sampler uniforms from TProgram
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.6k
- Forks
- 990
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 31
Description
bgfx uses TProgram::getNumLiveUniformVariables to get live uniforms to create reflection data. But it seems that sampler uniforms are not included. Is there a way to query sampler uniforms?
https://github.com/bkaradzic/bgfx/blob/master/tools/shaderc/shaderc_spirv.cpp#L737
https://github.com/bkaradzic/bgfx/issues/1689
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the referenced tools/shaderc/shaderc_spirv.cpp location and inspect how TProgram::getNumLiveUniformVariables is used to build reflection data. Compare that handling with the sampler-uniform behavior described in issue 1689. Done means establishing whether TProgram exposes sampler uniforms and documenting or correcting the supported query path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100