KhronosGroup / KhronosGroup/glTF

FB_geometry_metadata: Clarify meaning of "primitiveCount"

Open
#2,336 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
HTML
Stars
7.8k
Forks
1.2k
Avg merge
17h 26m
Merged PRs (30d)
5

Description

This is pretty simple, but on my first read of the [FB_geometry_metadata extension](https://github.com/KhronosGroup/glTF/tree/main/extensions/2.0/Vendor/FB_geometry_metadata) I thought that the `primitiveCount` referred to the number of Mesh Primitives in the scene. The example that's given indicating a `vertexCount` of 28727 and a `primitiveCount` of 15451, however, suggests that the intended meaning is the number of geometric primitives (triangles, lines, etc) that the scene contains. (Unless the example given represents a scene with a very high number of Primitives, each averaging 1.8 vertices, which seems... unlikely.)

In any case, because "Primitive" is used by the glTF spec to refer to something other than the geometric primitives that GPU APIs deal with, it's worth clarifying in the extension which meaning is intended to be applied here.

Contributor guide

Open the contributing guide

Research direction

Open the FB_geometry_metadata extension linked in the issue and read the definition of primitiveCount alongside the vertexCount and primitiveCount example. Clarify the term's intended meaning in the extension text so it cannot be confused with glTF Mesh Primitives; done means the distinction is explicit.

Written by the indexing model from the issue text.

Assessment

Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.