KhronosGroup / KhronosGroup/glTF-Validator

NODE_MATRIX_DEFAULT is slightly vauge warning.

Open
#209 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Dart
Stars
470
Forks
77
PR merge metrics
No merged PRs in 30d

Description

NODE_MATRIX_DEFAULT is vauge because it doesn't convey what it actually means. In the code, the issue is added when a node's matrix is an identity matrix. I understand this could be argued as an alternate way of saying this but last I checked identity matrix is the more common term.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating NODE_MATRIX_DEFAULT in the validator source and trace where the warning is added for a node whose matrix is an identity matrix. The work is done when the warning name clearly uses the identity-matrix terminology without changing the validation behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
dart
Domain
tooling
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.