KhronosGroup / KhronosGroup/glTF-Tutorials
Animations section image refers to node IDs instead of indices
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.3k
- Forks
- 215
- PR merge metrics
- No merged PRs in 30d
Description
The Image 7b at https://github.com/KhronosGroup/glTF-Tutorials/blob/main/gltfTutorial/gltfTutorial_007_Animations.md#animation-channels suggests that the animation channel target contains an id property that is a string.
This is a leftover from glTF 1.0 👴 In glTF 2.0, this id was replaced by node, which is an index into the nodes array of the glTF.
The image should be updated accordingly.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open gltfTutorial/gltfTutorial_007_Animations.md and locate Image 7b in the Animation Channels section. Update the image so the animation channel target uses the glTF 2.0 node index rather than an id string, then verify the rendered tutorial shows the corrected property.
Written by the indexing model from the issue text.
Assessment
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 85/100