KhronosGroup / KhronosGroup/glTF-Sample-Assets

Tangents likely incorrect for a couple meshes in two test assets

Open
#137 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.1k
Forks
107
Avg merge
9h 39m
Merged PRs (30d)
4

Description

Following the changes in #135, some test meshes were given `TANGENT` mesh attributes that may have been calculated from `TEXCOORD_1` instead of `TEXCOORD_0`. The assets in question are testing UV selection, not tangent space, so tests can still pass. But it might be nice to clean up the tangent attributes on the affected models, ClearCoatTest and TextureTransformMultiTest.

Contributor guide

Open the contributing guide

Research direction

Inspect the ClearCoatTest and TextureTransformMultiTest assets and locate their TANGENT and TEXCOORD_0 attributes. Verify whether the tangent data matches TEXCOORD_0 rather than TEXCOORD_1, then confirm both assets retain their UV-selection test coverage with corrected tangent attributes.

Written by the indexing model from the issue text.

Assessment

Domain
content
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.