KhronosGroup / KhronosGroup/glTF-Sample-Assets

VirtualCity model is not defining any lights and is closed by a single-sided dome

Open
#121 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.1k
Forks
107
Avg merge
9h 39m
Merged PRs (30d)
4

Description

The [VirtualCity](https://github.com/KhronosGroup/glTF-Sample-Assets/blob/main/Models/VirtualCity/glTF/VirtualCity.gltf) model will look completely black in a global illumination renderer because none of the materials define any emission and the city is enclosed by a single-sided dome geometry.

It _works_ when switching all materials to **unlit**.

The right way to implement self-illuminating objects (the surrounding dome, lit windows on the buildings) would have been to assign the textures currently used for the baseColorTexture to the emissiveTexture with an emissiveFactor of white (also or instead, depending on the intended surface material look).

Contributor guide

Open the contributing guide

Research direction

Start with Models/VirtualCity/glTF/VirtualCity.gltf and inspect its materials, textures, and dome geometry. Verify the model in a global illumination renderer; done means the dome and lit windows contribute emission and the city is no longer completely black without switching all materials to unlit.

Written by the indexing model from the issue text.

Assessment

Domain
computer-graphics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.