KhronosGroup / KhronosGroup/WebGL
Upstream unused uniform fixes to ES 3.0 suite, make harness stricter
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 2.9k
- Forks
- 704
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 4
Description
In https://github.com/KhronosGroup/WebGL/pull/340 the WebGL conformance suite harness for running the imported ES 3.0 tests was relaxed to be identically as strict as ES 3.0's GTF harness, because of problems with unreferenced uniforms being optimized away by some GLSL compilers. This was an expedient workaround for allowing the WebGL 1.0.2 conformance suite to be passed.
A better fix would be to fix the tests and make the ES 3.0 conformance suite harness stricter, requiring that all referenced uniforms be present. At that point the WebGL harness should me made stricter as well.
This is a follow-on to Issue 236.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing WebGL PR 340 and the related Issue 236 to understand the current ES 3.0 and WebGL conformance harness behavior. Inspect the imported ES 3.0 tests and harness, then make the tests and harness enforce referenced uniform presence before applying the same stricter behavior to the WebGL harness.
Written by the indexing model from the issue text.
Assessment
- Domain
- computer-graphics, testing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100