KhronosGroup / KhronosGroup/WebGL

No test case covering sampler operands

Open
#2,391 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
HTML
Stars
2.9k
Forks
703
Avg merge
2d 9h
Merged PRs (30d)
4

Description

ESSL 1.00 section 4.1.7, and ESSL 3.00 section.
Except for parameters to texture lookup functions, array indexing, structure field selection, and parentheses, samplers are not allowed to be operands in expressions.

Better to have some test cases to cover the rule. An ANGLE bug(https://bugs.chromium.org/p/angleproject/issues/detail?id=2028) can then be exposed.

Contributor guide

Open the contributing guide

Research direction

Start by locating the WebGL conformance tests for ESSL expression validation and the existing sampler-related cases. Add coverage for the operand restrictions described in ESSL 1.00 section 4.1.7 and ESSL 3.00, including the allowed contexts and disallowed expression operands; done means the tests expose violations such as the referenced ANGLE bug.

Written by the indexing model from the issue text.

Assessment

Domain
testing-qa
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.