KhronosGroup / KhronosGroup/Vulkan-ValidationLayers

gpuav: Allow use of selective shader instrumenation with regex in more cases

Open
#9,879 0 comments 0 reactions 1 assignee Claimed by @arno-lunarg View on GitHub
Enhancement GPU-AV
Dominant language
C++
Stars
1k
Forks
504
Avg merge
11h 35m
Merged PRs (30d)
224

Description

Follow up to https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/9855

Need to address this comment https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/9855#discussion_r2029041756

inlined here:

> They use vkCreateShaderModule, set name to VkPipeline
They use VK_KHR_maintenance5 to "inline", set name to VkPipeline

You set a VkPipeline name after creating it, so after instrumentation, can't easily go back to instrument?

> They use GPL, name the VkShaderModule in a library and destroy it

Not handled, I think I need new state tracking to do that? Since we instrument at pipeline linking time, at this point shader names will be lost along their corresponding module

> They use Shader Objects and set name to VkShaderEXT

Again issue of "object is instrumented at its creation time, so it can't have a debug name yet", would probably need a new system that upon first shader object usage, tries to see if it's eventual debug name appears in the list of shaders to instrument, and replace it with a newly instrumented shader?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.