KhronosGroup / KhronosGroup/Vulkan-ValidationLayers
Handle OpTerminateInvocation/OpKill for logging GPU-AV errors
- Dominant language
- C++
- Stars
- 1k
- Forks
- 504
- Avg merge
- 11h 35m
- Merged PRs (30d)
- 224
Description
https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/9841 added a `LogError` and a function that looks like
```C++
bool LogErrorPass::IsShaderExiting(const Instruction& inst) const {
return inst.Opcode() == spv::OpReturn || inst.Opcode() == spv::OpReturnValue;
}
```
We need tests and or at least a warning if the user uses `OpTerminateInvocation`/`OpKill` as it might not report errors
Contributor guide
Research direction
Review PR #9841 and the LogErrorPass::IsShaderExiting entry point first; the issue does not name a source file or test. Trace how OpTerminateInvocation and OpKill are handled, then add coverage or a warning showing that these paths do not silently miss errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100