KhronosGroup / KhronosGroup/Vulkan-ValidationLayers
Add Shader Object version of Undefined Value check
- Dominant language
- C++
- Stars
- 1k
- Forks
- 504
- Avg merge
- 11h 35m
- Merged PRs (30d)
- 224
Description
@ziga-lunarg pointed out in https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/9425/files the test was wrong
1. It is not invalid to do what we were doing (https://gitlab.khronos.org/vulkan/vulkan/-/issues/4186)
2. We have tests for this "Undefined Value" warning in `NegativeShaderInterface.CreatePipelineFragmentOutputNotConsumed`
3. (the issue) I realize we don't do that warning check with Shader Object. The code is in `ValidateFsOutputsAgainstRenderPass`/`ValidateFsOutputsAgainstDynamicRenderingRenderPass` and we could probably pipe those same 2 functions in the Shader Object path (and duplicate shader object version of those warnings)
Contributor guide
Assessment
This issue has not been assessed yet.