KhronosGroup / KhronosGroup/Vulkan-ValidationLayers
Have better system to skip validation if an error occurs
- Dominant language
- C++
- Stars
- 1k
- Forks
- 504
- Avg merge
- 11h 35m
- Merged PRs (30d)
- 224
Description
We have spots all over like this
```c++
skip |= ValidateCmd(*cb_state, error_obj.location);
if (skip) return skip; // basic validation failed, might have null pointers
```
For testing, this works because we have it so `LogError` will return `true`, but that is not always the case for a real usage
We need to create a way to propogate up if there was a validation error recorded or not. This might also be as easy as marking something in the `Logger` or `ErrorObject` class
Contributor guide
Research direction
Start by reviewing the existing ValidateCmd and LogError call patterns, including the skip and early-return flow shown in the issue. Then inspect Logger and ErrorObject as possible places to record validation errors; done means validation errors propagate reliably in real usage without depending on LogError returning true.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- testing-qa
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100