KhronosGroup / KhronosGroup/Vulkan-ValidationLayers

Build list of what possible handles need to be wrapped/unwrapped from a given function call

Open
#9,240 0 comments 0 reactions 0 assignees View on GitHub
codegen
Dominant language
C++
Stars
1k
Forks
504
Avg merge
11h 35m
Merged PRs (30d)
224

Description

We have had many issues in the past not detecting the Unwrap/Wrapping correctly.

It would be good to add some thing that would use the codegen logic to detect where the handles are and give warning when we forgot one

The most common case for this are the things in `dispatch_object_manual.cpp`, a new extension comes out that adds a pNext chain somewhere in one of those structs, and it doesn't get added until someone finally writes a tests for it

Contributor guide

Open the contributing guide

Research direction

Start by reading the codegen logic and the handle-wrapping paths in dispatch_object_manual.cpp to understand how pNext chains and related structs are currently handled. Done means producing warnings that identify handles requiring wrapping or unwrapping when a new case is missed, with coverage for the relevant dispatch paths.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.