KhronosGroup / KhronosGroup/Vulkan-ValidationLayers
Fix parent device check for EXT/KHR alias handles
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1k
- Forks
- 505
- Avg merge
- 11h 25m
- Merged PRs (30d)
- 229
Description
VUs like VUID-vkGetPipelinePropertiesEXT-pipeline-06738 and VUID-vkCreateFramebuffer-pCreateInfo-02777 currently are not working because the code gen is not handling the alias correctly
The alias of typedef VkPipelineInfoKHR VkPipelineInfoEXT; is making it so self.vk.commands['vkGetPipelinePropertiesEXT'].params[1].type == 'VkPipelineInfoEXT' is not in self.vk.struct
(test to help written in https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/9177)
(also VUID-vkCmdBeginRenderPass2-framebuffer-02779)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the code-generation logic that checks command parameter types against self.vk.struct and trace how EXT/KHR aliases are represented. Review the test described in pull request 9177, including the listed VUIDs, and verify that parent-device checks work for the alias handles in all three cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100