KhronosGroup / KhronosGroup/Vulkan-ValidationLayers
Add back VK_EXT_attachment_feedback_loop_layout drawtime check
- Dominant language
- C++
- Stars
- 1k
- Forks
- 504
- Avg merge
- 11h 35m
- Merged PRs (30d)
- 224
Description
Currently
- VUID-vkCmdDraw-None-09000
- VUID-vkCmdDraw-None-09001
- VUID-vkCmdDraw-None-09002
are not well defined and it lacks enough tests to make sure we are not giving out false positives
original code - https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/8096
-----
Edit: The 1.4.317 header changed these VUID to (then were updated again in 1.4.339 (https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/7961/diffs))
- VUID-vkCmdDraw-None-10795
- VUID-vkCmdDraw-None-10796
- VUID-vkCmdDraw-None-10797
Contributor guide
Research direction
Start by reviewing the original code in the linked pull request and the handling of VUID-vkCmdDraw-None-10795, -10796, and -10797. Restore the VK_EXT_attachment_feedback_loop_layout draw-time check and add enough tests to verify the validation does not produce false positives.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100