KhronosGroup / KhronosGroup/Vulkan-ValidationLayers

Missing coverage around VkMemoryRangeBarriersInfoKHR

Open
#12,923 0 comments 0 reactions 1 assignee Claimed by @artem-lunarg View on GitHub
Bug
Dominant language
C++
Stars
1k
Forks
504
Avg merge
11h 35m
Merged PRs (30d)
224

Description

From https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/12920 / https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/12921 it is clear that there is likely missing things around `VkMemoryRangeBarriersInfoKHR` (added from `VK_KHR_device_address_commands` ) that need to be properly added/tested

This struct is just `VkBufferMemoryBarrier2` be the `VkBuffer` was replaced with a `VkDeviceAddressRangeKHR` instead

- [ ] We should have a single positive test that uses `VkMemoryRangeBarriersInfoKHR`
- A test should also use it where multiple VkBuffer are tied to the same memory address range
- [ ] `CommandBufferSubState::UpdateEventWaitBarriers` seems to be missing something
- [ ] `CommandBufferSubState::RecordBarriers2` seems to not be recording anything
- [ ] `CommandBuffer::RecordBarrierObjects` doesn't seem to track it (via `TrackDeviceAddressRange`).
- The `AddChild` here is used to know that if you delete/free a `VkDeviceMemory` that the command buffer is not invalid
- [ ] `CompareDependencyInfo` is missing this, which might cause issues with VU `10788`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.