KhronosGroup / KhronosGroup/Vulkan-ValidationLayers
Validate vkCmdExecuteGeneratedCommandsEXT that token matches shader stage type
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1k
- Forks
- 505
- Avg merge
- 11h 25m
- Merged PRs (30d)
- 229
Description
looking at PositiveDeviceGeneratedCommands.ExecuteShaderObjectMesh I realize that there is no validation that when you call with a VK_INDIRECT_COMMANDS_TOKEN_TYPE_DRAW_MESH_TASKS_EXT token that a mesh shader is bound
likely the other way around as well too
This is just VUID-vkCmdDrawMeshTasksEXT-MeshEXT-07087 and VUID-vkCmdDraw-stage-06481 but for vkCmdExecuteGeneratedCommandsEXT
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the PositiveDeviceGeneratedCommands.ExecuteShaderObjectMesh test and inspect validation for vkCmdExecuteGeneratedCommandsEXT. Check both mismatches between the VK_INDIRECT_COMMANDS_TOKEN_TYPE_DRAW_MESH_TASKS_EXT token and the bound shader stage, using VUID-vkCmdDrawMeshTasksEXT-MeshEXT-07087 and VUID-vkCmdDraw-stage-06481 as references. Done means the invalid cases are reported and the relevant tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- api, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100