KhronosGroup / KhronosGroup/Vulkan-ValidationLayers
Missing validation if renderpass output is used as input attachment but not mapped with `vkCmdSetRenderingInputAttachmentIndices`
- Dominant language
- C++
- Stars
- 1k
- Forks
- 504
- Avg merge
- 11h 35m
- Merged PRs (30d)
- 224
Description
For details, please see this internal Vulkan issue: https://gitlab.khronos.org/vulkan/vulkan/-/issues/4687#note_591358
TL;DR is:
* Shader uses input attachment with `input_attachment_index=A, binding=B`
* Depth attachment's image view is bound to `binding=B` as input attachment
* `vkCmdSetRenderingInputAttachmentIndices` is _not_ used to map the depth attachment to input attachment
* Depth write is enabled
This is supposed to be invalid due to https://docs.vulkan.org/spec/latest/chapters/renderpass.html#renderpass-feedbackloop.
To reproduce, you can run the new tests in https://gerrit.khronos.org/c/vk-gl-cts/+/19613/1 (Note: take patchset 1, where I forgot to call `vkCmdSetRenderingInputAttachmentIndices`. Patchset 2 and later fix this test bug) and observe that syncval does not complain.
Contributor guide
Assessment
This issue has not been assessed yet.