KhronosGroup / KhronosGroup/Vulkan-ValidationLayers
Add missing VkSampleCount query
- Dominant language
- C++
- Stars
- 1k
- Forks
- 504
- Avg merge
- 11h 35m
- Merged PRs (30d)
- 224
Description
- [x] VUID-VkPhysicalDeviceSparseImageFormatInfo2-samples-01095
- [x] VUID-vkGetPhysicalDeviceSparseImageFormatProperties-samples-01094
Will need to call `vkGetPhysicalDeviceImageFormatProperties` and make sure the `samples` is a valid sample count
Also these
- [ ] VUID-VkAttachmentDescription-samples-08745
- [ ] VUID-VkAttachmentDescription2-samples-08745
- [ ] VUID-VkGraphicsPipelineCreateInfo-renderPass-08744
Contributor guide
Research direction
Start by locating the existing validation handling for the two checked sample-count VUIDs and the entry points covering the unchecked VUIDs. Review how vkGetPhysicalDeviceImageFormatProperties is called, then implement sample-count validation for the listed cases. Done means the three unchecked VUIDs are covered and the relevant validation checks pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100