KhronosGroup / KhronosGroup/Vulkan-ValidationLayers
Handle OpIgnoreIntersectionKHR and OpTerminateRayKHR
Open
CI/Tests
GPU-AV
RT
- Dominant language
- C++
- Stars
- 1k
- Forks
- 504
- Avg merge
- 11h 35m
- Merged PRs (30d)
- 224
Description
As discovered in https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/10003
We need a test that calls both `OpIgnoreIntersectionKHR` and `OpTerminateRayKHR` that reports an error
then we should add to `LogErrorPass::IsShaderExiting` once we know it is tested and won't blow up things
----
- [ ] I would want at least one negative test that would doing something invalid that the current code wouldn't catch (because the thread exits)
- [ ] We should have a "stress" test (for each) that adds `OpIgnoreIntersectionKHR`/`OpTerminateRayKHR` all over to make sure we don't blow up a compiler with control flow issues
Contributor guide
Assessment
This issue has not been assessed yet.