KhronosGroup / KhronosGroup/Vulkan-Utility-Libraries

`safe_VkPipelineCacheCreateInfo` does not copy its pInitialData from `in_struct`

Open
#343 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
103
Forks
49
Avg merge
7h 15m
Merged PRs (30d)
4

Description

The current codegen for `vku::safe_VkPipelineCacheCreateInfo` does not copy its souce contents, only the source pointer.

```c++
void safe_VkPipelineCacheCreateInfo::initialize(const VkPipelineCacheCreateInfo* in_struct,
[[maybe_unused]] PNextCopyState* copy_state) {
FreePnextChain(pNext);
sType = in_struct->sType;
flags = in_struct->flags;
initialDataSize = in_struct->initialDataSize;
pInitialData = in_struct->pInitialData;
pNext = SafePnextCopy(in_struct->pNext, copy_state);
}
```

Contributor guide

Open the contributing guide

Research direction

Search for safe_VkPipelineCacheCreateInfo::initialize and the codegen that produces it; compare how pInitialData is handled with other pointer fields. The issue is done when the initializer copies the pointed-to initial data rather than retaining only the source pointer, with existing relevant tests or generated output confirming the behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.